Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2A Boom: Install pre-compiled binaries #392

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

sksat
Copy link
Member

@sksat sksat commented Nov 28, 2024

  • Introduce C2A Boom to example users #56 で導入した C2A Boom のツール群のインストールがこれまでソースファイルからのビルド(npm/pnpm install 時に裏で cargo build が走っていた)を行っていたものを、バイナリをダウンロードするように変更します
  • C2A 開発者のオンボーディング時にみなさんの PC を暖めずに済むようになります

@sksat sksat added priority::high priorityg high tools labels Nov 28, 2024
@sksat sksat self-assigned this Nov 28, 2024
@sksat sksat force-pushed the feature/c2a-boom-precompiled-binaries branch from 6b47286 to 272cf3e Compare November 28, 2024 13:06
@sksat
Copy link
Member Author

sksat commented Nov 28, 2024

tlmcmddb.json......

@sksat sksat requested a review from KOBA789 December 5, 2024 15:12
@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

@KOBA789 バイナリ配布開始につき approve 求む

@KOBA789
Copy link
Member

KOBA789 commented Dec 5, 2024

tlmcmddb-cli v2.6.1 のレビューを先にした方がいい気がするのでちょい待って

@KOBA789
Copy link
Member

KOBA789 commented Dec 5, 2024

jrsonnet は依然として PC 暖める方針?

@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

jrsonnet は pre-release の versioning が滅茶苦茶で素直に cargo-binstall できないので、やるとしても PR 分けようかと思ってます

@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

あんまり分ける必要無いか

@sksat
Copy link
Member Author

sksat commented Dec 5, 2024

jrsonnet は(やや癪ですが)curl で取ってくるようにしました

@sksat sksat merged commit 97972a0 into main Dec 9, 2024
37 checks passed
@sksat sksat deleted the feature/c2a-boom-precompiled-binaries branch December 9, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants